Source environment relatively from script path in bin/setup#1403
Open
CasEbb wants to merge 1 commit intomarkshust:release/nextfrom
Open
Source environment relatively from script path in bin/setup#1403CasEbb wants to merge 1 commit intomarkshust:release/nextfrom
bin/setup#1403CasEbb wants to merge 1 commit intomarkshust:release/nextfrom
Conversation
PR Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When following the installation instructions from the readme, running
bin/setupyields a warningmagento.env file not found. This is because the environment is sourced from../env/magento.env, and assuming we're running the script in$PWD, it is trying to source the env from$PWD/../env/magento.env, while the file is in$PWD/env/magento.env(assuming we didn'tcdintobin/).This PR changes
bin/setupto prepend the paths with the script dir so it always findsmagento.envregardless of the working directory. This is also probably a more durable solution than the one proposed in #1385.