Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 82.99% 82.99%
=======================================
Files 1 1
Lines 147 147
=======================================
Hits 122 122
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The error on readthedocs must be a glitch ( The stable build is failing because that image is still using python<3.10, so there is a version conflict. Let me try real quick to move back the requirement to see if at least the RTD build passes |
54c426f to
1c6c95f
Compare
|
Finally ready @marcomangano @A-CGray |
marcomangano
left a comment
There was a problem hiding this comment.
I gave a quick pass and it is looking good. This is only tested locally, correct? Do we have any notes about that?
| self.mydvs = list(range(ndvs)) | ||
|
|
||
| def _eval_func(self, x: ndarray) -> Tuple[ndarray, ndarray, bool]: | ||
| def _eval_func(self, x: ndarray) -> tuple[ndarray, ndarray, bool]: |
There was a problem hiding this comment.
Should we use the numpy-specific array type here as well?
Purpose
Just some long-overdue type annotations
Expected time until merged
A few days
Type of change
Testing
Checklist
ruff checkandruff formatto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable