Skip to content

Update types#466

Open
ewu63 wants to merge 13 commits intomainfrom
update-types
Open

Update types#466
ewu63 wants to merge 13 commits intomainfrom
update-types

Conversation

@ewu63
Copy link
Copy Markdown
Collaborator

@ewu63 ewu63 commented Nov 16, 2025

Purpose

Just some long-overdue type annotations

Expected time until merged

A few days

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner November 16, 2025 22:37
@ewu63 ewu63 requested review from kanekosh and sanjan98 November 16, 2025 22:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.99%. Comparing base (92cd835) to head (c0b01bd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files           1        1           
  Lines         147      147           
=======================================
  Hits          122      122           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcomangano marcomangano mentioned this pull request Nov 17, 2025
13 tasks
@marcomangano marcomangano self-requested a review as a code owner December 12, 2025 17:00
@marcomangano
Copy link
Copy Markdown
Collaborator

The error on readthedocs must be a glitch (setuptools missing from the environment?) because the other PRs are not having the same issue.

The stable build is failing because that image is still using python<3.10, so there is a version conflict. Let me try real quick to move back the requirement to see if at least the RTD build passes

@ewu63 ewu63 force-pushed the update-types branch 5 times, most recently from 54c426f to 1c6c95f Compare March 12, 2026 22:55
@ewu63
Copy link
Copy Markdown
Collaborator Author

ewu63 commented May 3, 2026

Finally ready @marcomangano @A-CGray

Copy link
Copy Markdown
Collaborator

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave a quick pass and it is looking good. This is only tested locally, correct? Do we have any notes about that?

self.mydvs = list(range(ndvs))

def _eval_func(self, x: ndarray) -> Tuple[ndarray, ndarray, bool]:
def _eval_func(self, x: ndarray) -> tuple[ndarray, ndarray, bool]:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the numpy-specific array type here as well?

@A-CGray
Copy link
Copy Markdown
Member

A-CGray commented May 7, 2026

How do you want to handle this PR relative to #483 @ewu63? Merge that first then add typing for the Uno wrapper in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants