Skip to content

Add delete_all option to label updates.#121

Open
Gerrit91 wants to merge 4 commits intomainfrom
label-strategy
Open

Add delete_all option to label updates.#121
Gerrit91 wants to merge 4 commits intomainfrom
label-strategy

Conversation

@Gerrit91
Copy link
Copy Markdown
Contributor

@Gerrit91 Gerrit91 commented Apr 2, 2026

Description

References metal-stack/metal-apiserver#65 (comment).

This would allow to implement the CLI with --add-label and --remove-label as we intended. For certain programmatic use-cases we can now also send delete_all and just specify the labels that we want to have.

Used AI-Tools ✨

  • None used for generation

@Gerrit91 Gerrit91 marked this pull request as ready for review April 9, 2026 07:11
@Gerrit91 Gerrit91 requested a review from a team as a code owner April 9, 2026 07:11
Comment on lines +132 to +138
cel: [
{
id: "keys_trimmed"
message: "keys must be trimmed"
expression: "this.trim().size() == this.size()"
}
]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now managed to write a predefined rule for this

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be seen in #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants