Debug logging of signature application#7803
Merged
Conversation
When debug logging is enabled, decode the COSE protected header after successfully verifying a backup signature in verify_root_signatures() and log the TxID and issued-at timestamp (formatted as x509 time string). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Only decode the COSE protected header to extract iat when DEBUG logging is enabled, avoiding unnecessary work on the hot path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
cjen1-msft
approved these changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds optional DEBUG-level logging during COSE root signature verification in the node history component, to surface receipt metadata (TxID and issuance time) when available.
Changes:
- Adds receipt decoding and DEBUG log on successful COSE signature verification.
- Adds X.509 time formatting for the logged
iattimestamp. - Includes COSE receipt decoding utilities needed for the debug-only path.
eddyashton
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.