Make sure COSE Rust Debug/Release is consistent with CCF#7823
Merged
maxtropets merged 3 commits intomainfrom Apr 16, 2026
Merged
Make sure COSE Rust Debug/Release is consistent with CCF#7823maxtropets merged 3 commits intomainfrom
maxtropets merged 3 commits intomainfrom
Conversation
maxtropets
commented
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Aligns the Rust cose-rs Cargo build profile (debug vs release) with CMake’s CMAKE_BUILD_TYPE, and prevents accidental profile mismatches.
Changes:
- Rejects multi-config CMake generators to avoid Cargo profile/build-type drift.
- Maps
CMAKE_BUILD_TYPEto a Cargo profile flag and library output directory. - Improves build logging and uses the selected Cargo profile in the custom target.
cjen1-msft
approved these changes
Apr 16, 2026
Contributor
cjen1-msft
left a comment
cjen1-msft
left a comment
There was a problem hiding this comment.
I'd debated this previously.
I think this is probably the right thing.
However. As CCF is a consumer of the rust here, an argument could be made that it should be release-only.
But, afaicr release doesn't emit symbols, so for debugging e2e issues I think this is useful.
achamayou
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.