Skip to content

ci: run macOS tests only post-merge (push event) #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harsha-simhadri wants to merge 1 commit into from
+4 −9
Closed

ci: run macOS tests only post-merge (push event) #1048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,11 +367,8 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os:
- windows-latest
- ubuntu-latest
- ubuntu-24.04-arm
- macos-latest
# Include macOS only on push (post-merge) to avoid slowing down PR checks.
os: ${{ github.event_name == 'push' && fromJSON('["windows-latest","ubuntu-latest","ubuntu-24.04-arm","macos-latest"]') || fromJSON('["windows-latest","ubuntu-latest","ubuntu-24.04-arm"]') }}
Copy link
Copy Markdown
Contributor Author

@harsha-simhadri harsha-simhadri May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark, nested conditionals dont work on github CI. so back to ternary

Copy link
Copy Markdown
Contributor

@hildebrandmw hildebrandmw May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this kind of incremental complexity. IMO, adding incremental changes like this will eventually make it quite hard to reason about CI.

Is it worth instead having a second CI step for post-merge operations rather than trying to do everything in ci.yml.

Additionally, I currently don't receive any kind of notification for post-merge failures, and our post-merge miri job takes a whopping 45 minutes. Should we instead move to a nightly run and lump everything there?

By big concerns are:

  • Keeping ci.yml straight forward.
  • Ensuring post merge jobs generate signal.

Copy link
Copy Markdown
Contributor Author

@harsha-simhadri harsha-simhadri May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1051

Copy link
Copy Markdown
Contributor Author

@harsha-simhadri harsha-simhadri May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arrayka are you ok with moving miri to nightly. I can send PR for that


steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -400,10 +397,8 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os:
- windows-latest
- ubuntu-latest
- macos-latest
# Include macOS only on push (post-merge) to avoid slowing down PR checks.
os: ${{ github.event_name == 'push' && fromJSON('["windows-latest","ubuntu-latest","macos-latest"]') || fromJSON('["windows-latest","ubuntu-latest"]') }}

steps:
- uses: actions/checkout@v4
Expand Down
Loading