Support file-based serialize/deserialize for DiskANN indices using Save/Load traits#1079
Draft
suhasjs wants to merge 21 commits into
Draft
Support file-based serialize/deserialize for DiskANN indices using Save/Load traits#1079suhasjs wants to merge 21 commits into
suhasjs wants to merge 21 commits into
Conversation
…borrow for Writer::finish() since it calls std::io::Write::flush() that needs a mutable borrow
…ave::Results<Handle>
…w directly impls for Value<'static>
… wherever needed + modify writer return type to Result<>
… required for their Load/Save impls)
… diskann-providers with a new SingleUseWriteProvider (also for reads with SingleUseReadProvider)
…ad_from_bin<> to only use one read since VectorDataIterator already has the metadata needed for
…ghborProviderAsync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Initial attempt at #737
What does this implement/fix? Briefly explain your changes.
Introduces two new traits (
diskann_record::save::Saveanddiskann_record::load::Load)and a new creatediskann-recordto support file-based serialization + deserialization. This PR also implements the traits forDiskANNIndex(and all nested structs) for a successful prototype.Sample output can be found here.
Any other comments?
This PR is meant to be in a draft state until we're happy with the abstractions and the results.