FIX: Converter Mixed Media Types#1719
Open
jbolor21 wants to merge 3 commits into
Open
Conversation
romanlutz
reviewed
May 13, 2026
Comment on lines
+178
to
+180
| {convertedFileChip.iconKind === 'image' && '🖼️'} | ||
| {convertedFileChip.iconKind === 'audio' && '🎵'} | ||
| {convertedFileChip.iconKind === 'video' && '🎥'} |
Contributor
There was a problem hiding this comment.
can we not render these? file is different, of course, but image, audio, video at least? Would be nice to be able to play audio/video and see image
romanlutz
approved these changes
May 13, 2026
Contributor
romanlutz
left a comment
romanlutz
left a comment
There was a problem hiding this comment.
Do we want to add/update e2e tests for converters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the converter GUI panel, when we use the converters to change media types (ie add text to image: text -> image or PDFconverter takes text -> binary file output) this PR now shows the converted file as a file rather than text and lets you open the converted file as well!
Screenshots:
Before fix:
Tests and Documentation
Ran existing tests & added new tests for testing the new "open" file button loads and renders a file