Skip to content

Improve gh-aw agent support and fix PR docs check#16019

Merged
IEvangelist merged 2 commits intomicrosoft:mainfrom
IEvangelist:dapine/fix-pr-docs-check-discussions
Apr 14, 2026
Merged

Improve gh-aw agent support and fix PR docs check#16019
IEvangelist merged 2 commits intomicrosoft:mainfrom
IEvangelist:dapine/fix-pr-docs-check-discussions

Conversation

@IEvangelist
Copy link
Copy Markdown
Member

@IEvangelist IEvangelist commented Apr 9, 2026

Description

  • Updates pr-docs-check to set safe-outputs.add-comment.discussions: false, which prevents gh-aw from requesting the invalid discussion permissions tracked by github/gh-aw#25467.
  • Sets on.stale-check: false so the compiled lock file can intentionally retain the required aspire.dev safe-output checkout overrides.
  • Regenerates .github/workflows/pr-docs-check.lock.yml and preserves the required path: aspire.dev and working-directory: aspire.dev settings for the cross-repo PR flow.
  • Installs the gh aw CLI extension in .github/workflows/copilot-setup-steps.yml so Copilot cloud runs can use the gh-aw tooling.
  • Adds .github/agents/agentic-workflows.agent.md as a dispatcher agent for gh-aw create/update/debug/upgrade/report workflows.
  • Simplifies .vscode/mcp.json to the supported MCP servers used in this repo.
  • Validation: gh aw compile pr-docs-check

Fixes #15927

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Opt out of add-comment discussion support so gh-aw stops generating invalid discussion permissions, and disable stale checking so the lock file can retain the required aspire.dev safe-output checkout path overrides.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 9, 2026 21:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16019

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16019"

Install the gh-aw CLI extension in copilot-setup-steps, add the agentic-workflows dispatcher agent, and simplify the local MCP config to the supported servers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@IEvangelist IEvangelist changed the title Fix PR docs check safe-output permissions Improve gh-aw agent support and fix PR docs check Apr 9, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pr-docs-check agentic workflow configuration to avoid requesting invalid GitHub App permissions (tracked in github/gh-aw#25467) and to preserve required cross-repo safe-output checkout overrides in the compiled lock workflow.

Changes:

  • Disables discussion support for safe-outputs.add-comment to prevent discussions permission requests.
  • Disables stale-check to allow intentional lock-file overrides to persist.
  • Regenerates pr-docs-check.lock.yml to reflect the updated safe-outputs configuration and permissions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/pr-docs-check.md Updates workflow source to disable stale-check and opt out of discussions for add-comment.
.github/workflows/pr-docs-check.lock.yml Regenerated compiled workflow reflecting new safe-outputs settings and updated permissions.

Comment thread .github/workflows/pr-docs-check.lock.yml
Comment thread .github/workflows/pr-docs-check.lock.yml
@IEvangelist IEvangelist merged commit 2f61fef into microsoft:main Apr 14, 2026
265 checks passed
@joperezr joperezr added this to the 13.3 milestone Apr 14, 2026
radical pushed a commit that referenced this pull request Apr 14, 2026
* Fix PR docs check safe-output permissions

Opt out of add-comment discussion support so gh-aw stops generating invalid discussion permissions, and disable stale checking so the lock file can retain the required aspire.dev safe-output checkout path overrides.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add gh-aw agent support files

Install the gh-aw CLI extension in copilot-setup-steps, add the agentic-workflows dispatcher agent, and simplify the local MCP config to the supported servers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] PR Documentation Check failed

4 participants