[release/13.2] Remove telemetry API data limits and refactor URL builders#16023
Merged
joperezr merged 4 commits intorelease/13.2from Apr 14, 2026
Merged
[release/13.2] Remove telemetry API data limits and refactor URL builders#16023joperezr merged 4 commits intorelease/13.2from
joperezr merged 4 commits intorelease/13.2from
Conversation
- Remove MaxQueryCount from TelemetryApiService, use int.MaxValue so storage queries return all data and limits are controlled by callers. - Add TelemetryCommandHelpers.MaxTelemetryLimit (int.MaxValue) for CLI export and MCP tools to fetch all available telemetry data. - Refactor DashboardUrls telemetry URL builders from params tuples to explicit named parameters matching MapTelemetryApi endpoints. - Replace BuildQueryString with AddQueryString pattern for consistency. - Update tests for new URL builder signatures and large limit scenarios.
Add GetSpans_WithLimit_ReturnsMostRecentSpans, GetTraces_WithLimit_ReturnsMostRecentTraces, and GetLogs_WithLimit_ReturnsMostRecentLogs tests to TelemetryApiServiceTests.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16023Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16023" |
…lemetrySpansCommand
mitchdenny
approved these changes
Apr 10, 2026
Contributor
|
🎬 CLI E2E Test Recordings — 53 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24222694361 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16020 to release/13.2
/cc @JamesNK
Customer Impact
User reported bug at https://x.com/SimCabana/status/2042251356833005574. There is a limit on telemetry returned from APIs and the export command isn't overriding it. The output zip doesn't contain expected results.
The fix is to specify a max limit so all data is in the zip file.
Testing
Unit and manual testing
Risk
Low
Regression?
No, this is a new feature