Skip to content
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
using System.Net;
using System.Security.Cryptography;
using System.Threading;
using System.Threading.Channels;
using System.Threading.Tasks;
using Hl7.Fhir.Model;
using Microsoft.Health.Extensions.Xunit;
Expand Down Expand Up @@ -38,6 +39,58 @@
_isSql = _fixture.DataStore == DataStore.SqlServer;
}

[Fact]
public async Task Given1000SearchParams_WhenReindexCompletes_ThenSearchParamsAreEnabled()
{
await CancelAnyRunningReindexJobsAsync();

const int numberOfSearchParams = 1000;

var searchParams = new List<SearchParameter>();
try
{
// this takes 8 minutes locally
await Parallel.ForAsync(0, numberOfSearchParams, new ParallelOptions { MaxDegreeOfParallelism = 8 }, async (i, cancel) =>
{
var randomSuffix = Guid.NewGuid().ToString("N").Substring(0, 8);
var searchParam = await CreateCustomSearchParameterAsync($"custom-person-name-{randomSuffix}", ["Person"], "Person.name.given", SearchParamType.String);
Assert.NotNull(searchParam);
lock (searchParam)
{
searchParams.Add(searchParam);
}
});

var parameters = new Parameters
{
Parameter =
[
new Parameters.ParameterComponent { Name = "maximumNumberOfResourcesPerQuery", Value = new Integer(1) },
new Parameters.ParameterComponent { Name = "maximumNumberOfResourcesPerWrite", Value = new Integer(1) },
],
};

var value = ((FhirResponse<Parameters> response, Uri jobUri))await _fixture.TestFhirClient.PostReindexJobAsync(parameters);
Comment thread Fixed
Assert.Equal(HttpStatusCode.Created, value.response.Response.StatusCode);

await WaitForJobCompletionAsync(value.jobUri, TimeSpan.FromSeconds(300));

await Task.Delay(TimeSpan.FromSeconds(10));

await Parallel.ForEachAsync(searchParams, new ParallelOptions { MaxDegreeOfParallelism = 8 }, async (param, cancel) =>
{
await VerifySearchParameterIsEnabledAsync($"Person?{param.Code}=Test", param.Code);
});
}
finally
{
await Parallel.ForEachAsync(searchParams, new ParallelOptions { MaxDegreeOfParallelism = 8 }, async (param, cancel) =>
{
await _fixture.TestFhirClient.DeleteAsync($"SearchParameter/{param.Id}");
});
}
}

[Fact]
public async Task GivenReindexJobWithConcurrentUpdates_ThenReportedCountsAreLessThanOriginal()
{
Expand Down Expand Up @@ -921,6 +974,15 @@
oo.Issue?.Any(i => i.Code?.ToString() == "NotSupported") == true) ?? false;
}

private async Task VerifySearchParameterIsEnabledAsync(string searchQuery, string searchParameterCode)
{
var response = await _fixture.TestFhirClient.SearchAsync(searchQuery);
Assert.NotNull(response);
var error = HasNotSupportedError(response.Resource);
Assert.False(error, $"Search param {searchParameterCode} is NOT supported after reindex.");
return;
}

/// <summary>
/// Verifies that a search parameter is properly indexed and working by executing a search query with retry logic.
/// Retries handle timing issues with search parameter cache refresh after reindex operations.
Expand Down
Loading