Fix display units of stats counters#1245
Closed
tmcdonell wants to merge 1 commit intomicrosoft:dev3from
Closed
Conversation
daanx
added a commit
that referenced
this pull request
Apr 12, 2026
Collaborator
|
Thank you for the PR! I studied it but decided to take a slightly different approach. Let me know if this works for you. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the units that stats are displayed in. Previously all counters were printed in binary mode, which is not always the natural unit (e.g.
commits: 35.4 Kivscommits: 40.5 K).Example:
env MIMALLOC_SHOW_STATS=1 ./build/mimalloc-test-stressBefore
After