Skip to content

Commit 23d470b

Browse files
http-client-java, fix singular on caches (#10338)
"Caches" singular form should be "Cache"
1 parent 3e428bb commit 23d470b

3 files changed

Lines changed: 14 additions & 0 deletions

File tree

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
changeKind: fix
3+
packages:
4+
- "@typespec/http-client-java"
5+
---
6+
7+
Fix bug that singular form of "Caches" is incorrect

packages/http-client-java/generator/http-client-generator-mgmt/src/main/java/com/microsoft/typespec/http/client/generator/mgmt/util/Utils.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,10 @@ public static String getNameForUngroupedOperations(Client client, FluentJavaSett
4444
return nameForUngroupOperations;
4545
}
4646

47+
static {
48+
Pluralize.addSingularRule("caches", "cache");
49+
}
50+
4751
public static String getSingular(String name) {
4852
if (name == null) {
4953
return null;

packages/http-client-java/generator/http-client-generator-mgmt/src/test/java/com/microsoft/typespec/http/client/generator/mgmt/util/FluentUtilsTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,9 @@ public void testGetSingular() {
9797
// irregular (children → child)
9898
Assertions.assertEquals("child", FluentUtils.getSingular("children"));
9999

100+
// require addSingularRule
101+
Assertions.assertEquals("Cache", FluentUtils.getSingular("Caches"));
102+
100103
// Azure resource style names
101104
Assertions.assertEquals("VirtualMachine", FluentUtils.getSingular("VirtualMachines"));
102105
Assertions.assertEquals("NetworkInterface", FluentUtils.getSingular("NetworkInterfaces"));

0 commit comments

Comments
 (0)