fix: use backtick template literal in NoChangeError message#310741
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: use backtick template literal in NoChangeError message#310741Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
- Import ToolName from toolNames to enable proper template interpolation
- Change single quotes to backticks so ${ToolName.ReadFile} becomes 'read_file'
- Fix doubled word 'and and' to 'and'
Fixes microsoft#308365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
Summary
Fixed two issues in the NoChangeError message in
editFileToolUtils.tsx:Broken template interpolation: Single-quoted strings do not support
${...}interpolation in JavaScript/TypeScript. The model literally received the text${ToolName.ReadFile}instead ofread_file. Added the missingToolNameimport and changed to backtick template literal.Doubled word typo: Fixed
and andtoand.Changes
import { ToolName } from '../common/toolNames';re-read the file and and determine→re-read the file and determineTesting
Fixes #308365
Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly.
Warmly,
RoomWithOutRoof