fix: set isNESForAnotherDoc correctly for cross-file NES#310794
Merged
fix: set isNESForAnotherDoc correctly for cross-file NES#310794
Conversation
Previously isNESForAnotherDoc was only set inside addNotebookTelemetry, so non-notebook cross-file NES always reported false. - Set the flag on the main edit path for all cases (notebook and non-notebook) - Set the flag on the jump-to-position path when targetDocumentId differs - Set the flag and status 'noEdit:crossFileTargetNotFound' when cross-file target document is not found in the workspace - Remove redundant setIsNESForOtherEditor call from addNotebookTelemetry
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes enhanced telemetry so isNESForAnotherDoc is correctly reported for cross-file Next Edit Suggestions (NES), not just for notebook cases, improving telemetry accuracy for editor-to-editor suggestions.
Changes:
- Set
isNESForAnotherDoc(setIsNESForOtherEditor) on the main edit path for both notebook and non-notebook scenarios. - Set
isNESForAnotherDocon the jump-to-position-only path whentargetDocumentIddiffers from the current document. - When a cross-file target document can’t be resolved, set
isNESForAnotherDocand a dedicated status (noEdit:crossFileTargetNotFound), and remove the redundant notebook-only setter.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/inlineEdits/vscode-node/inlineCompletionProvider.ts | Ensures cross-file (and jump-only) NES telemetry correctly marks “other document” cases and records a specific status when the cross-file target cannot be found. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
dmitrivMS
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously isNESForAnotherDoc was only set inside addNotebookTelemetry, so non-notebook cross-file NES always reported false.