Skip to content

Fix add_batch_request_item #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 6 commits into from
Mar 24, 2025
Merged

Fix add_batch_request_item #848

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b7a40b
fix batch creation
Mar 11, 2025
e04db72
fix batch creation
Mar 11, 2025
d83b294
fix
Mar 11, 2025
42294b1
tests
Mar 22, 2025
df257ba
Merge branch 'main' into main
GeorgeOG Mar 22, 2025
d907978
Merge branch 'main' into main
GeorgeOG Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/msgraph_core/requests/batch_request_content_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ def __init__(self) -> None:

"""
self.max_requests_per_batch = BatchRequestContent.MAX_REQUESTS
self.batches: list[BatchRequestContent] = []
self.current_batch: BatchRequestContent = BatchRequestContent()
self.batches: list[BatchRequestContent] = [self.current_batch]

def add_batch_request_item(self, request: BatchRequestItem) -> None:
"""
Expand All @@ -26,10 +26,10 @@ def add_batch_request_item(self, request: BatchRequestItem) -> None:
request (BatchRequestItem): The request item to add.
"""
if len(self.current_batch.requests) >= self.max_requests_per_batch:
self.batches.append(self.current_batch.finalize())
self.current_batch.finalize()
self.current_batch = BatchRequestContent()
self.batches.append(self.current_batch)
self.current_batch.add_request(request.id, request)
self.batches.append(self.current_batch)

def remove_batch_request_item(self, request_id: str) -> None:
"""
Expand Down