This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Fleshed out the client protocol unit tests.#16
Open
kward wants to merge 8 commits intomitchellh:masterfrom
Open
Fleshed out the client protocol unit tests.#16kward wants to merge 8 commits intomitchellh:masterfrom
kward wants to merge 8 commits intomitchellh:masterfrom
Conversation
- Split handshake() into separate functions - Created ClientIO interface to enable mocking - Added unit tests for clientInit()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull fleshes out many of the client protocol calls, validates proper protocol handling or reasonable failures, and includes some minor changes to make testing easier.
I'm doing this in preparation to support the basic auth RFB 003.003 as provided separately by xenserverarmy.