Port spatialaudio module to libspatialaudio 0.4.0 API#1245
Merged
Conversation
- Require libspatialaudio >= 0.4.0 in pkg_check_modules - Add 'using namespace spaudio' for the new namespace - Rename class prefixes: CAmbisonicX -> AmbisonicX, CBFormat -> BFormat - Update AmbisonicDecoder::Configure to include sampleRate parameter - Update AmbisonicEncoder::Configure signature (sampleRate, fadeTime) - Update AmbisonicZoomer::Configure to pass sampleRate - Replace PolarPoint with PolarPosition<float> and update field names - Use Orientation constructor instead of aggregate initialization - Use scoped enum Amblib_SpeakerSetUps for speaker layout constants - Remove gain parameter from AmbisonicEncoder::SetPosition Agent-Logs-Url: https://github.com/mltframework/mlt/sessions/c98c5021-60b6-49ce-bc41-77f91e8cfce0 Co-authored-by: ddennedy <1146683+ddennedy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix spatialaudio module build issue with upstream releases
Port spatialaudio module to libspatialaudio 0.4.0 API
May 11, 2026
Member
|
@copilot I gave you access to https://api.github.com, and format the code with clang-format-14 and our config file for it (or see the job failures). |
Agent-Logs-Url: https://github.com/mltframework/mlt/sessions/c1b45048-d3a0-4fd0-aebd-e3689f1003a8 Co-authored-by: ddennedy <1146683+ddennedy@users.noreply.github.com>
Contributor
Author
Applied clang-format-14 with the repo's |
ddennedy
approved these changes
May 11, 2026
Member
ddennedy
left a comment
ddennedy
left a comment
There was a problem hiding this comment.
This builds locally against 0.4.0, and the changes are very straightforward renames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMakeLists.txtto require libspatialaudio >= 0.4.0filter_ambisonic-decoder.cppfor 0.4.0 API (namespace, class names, Configure signatures, enum scoping)filter_ambisonic-encoder.cppfor 0.4.0 API (namespace, class names, Configure signature, PolarPosition)