Fix Issue with Extras Installation/Updates#16950
Merged
opengeek merged 2 commits intomodxcms:3.xfrom May 4, 2026
Merged
Conversation
Fix infinite loop issue in base remove method
smg6511
added
urgent
opengeek
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Corrected reference to parent
removemethod in base grids class. When refactoring the grids classes, adding a new base class, the change needed for this line was overlooked (creating an infinite loop when encountered).How to test
Note: Either set
compress_jsto “No” or rungrunt buildIt's difficult to identify the exact conditions that trigger this issue. I believe this is related to Extras that include a grid (such as a dependencies grid) as a part of the installation process. I was able to replicate the loop issue when updating Formit. The best way to test this may be to install and update multiple Extras, while keeping the browser console open. Verify errors are not triggered and the install process works as expected.
Related issue(s)/PR(s)
Resolves #16946
Compatibility notes
n/a
Breaking change assessment
n/a
Test coverage
n/a - No UTs implemented for Extjs
Contributors
@SnowCreative
AI tool use
n/a