Update FC Set grids - Correct group headers config#16951
Open
smg6511 wants to merge 1 commit intomodxcms:3.xfrom
Open
Update FC Set grids - Correct group headers config#16951smg6511 wants to merge 1 commit intomodxcms:3.xfrom
smg6511 wants to merge 1 commit intomodxcms:3.xfrom
Conversation
Remove custom groupTextTpl and make minor tweaks to grid column groupability and Lexicon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
groupTextTplfor two grid configs, deferring to the already-established base configAside from minor enhancements, the change is to guard against future problems as noted in the related issue.
How to test
tvs_longvalue toTemplate's Variables(adding a single quote as shown or double quote if you wish, with or without backslash escape), refresh the cache and ensure the Template Variables grid (3rd tab) still displays as expected. Note that this text is used in each group's header, e.g., “Category: None (2 Template Variables)” or, in the case of the first tab's grid, “Region (ID): modx-page-settings-box-left (6 Fields)” if changing thefieldorfieldsLexicontvs_longand add an escaped single quote in the value, again clearing cache and verifying grid operation. I add this as the custom db entries might already be encoded (I didn't look into this, but I wouldn't be surprised if they are)Related issue(s)/PR(s)
Resolves #16948
Compatibility notes
n/a
Breaking change assessment
n/a
Test coverage
n/a for Extjs
Contributors
@opengeek
AI tool use
n/a