Skip to content

Update FC Set grids - Correct group headers config#16951

Open
smg6511 wants to merge 1 commit intomodxcms:3.xfrom
smg6511:3.x-issue-16948
Open

Update FC Set grids - Correct group headers config#16951
smg6511 wants to merge 1 commit intomodxcms:3.xfrom
smg6511:3.x-issue-16948

Conversation

@smg6511
Copy link
Copy Markdown
Collaborator

@smg6511 smg6511 commented May 7, 2026

What changed and why

  • Removed custom groupTextTpl for two grid configs, deferring to the already-established base config
  • Make columns with primarily unique values ungroupable
  • Fix the rendering when grouping by visibility
  • Update Lexicons to make display consistent (i.e., previously the plural form for the TVs grid read "Template Variables" and the singular "TV;" added entries for abbreviated and long forms of this term, changing the singular in this grid to "Template Variable."

Aside from minor enhancements, the change is to guard against future problems as noted in the related issue.

How to test

  1. Clear browser and MODX caches
  2. Visit a Form Customization Set (preferably with multiple entries) to verify grids operate as expected.
  3. Change the Lexicon via the manager for the default topic's tvs_long value to Template's Variables (adding a single quote as shown or double quote if you wish, with or without backslash escape), refresh the cache and ensure the Template Variables grid (3rd tab) still displays as expected. Note that this text is used in each group's header, e.g., “Category: None (2 Template Variables)” or, in the case of the first tab's grid, “Region (ID): modx-page-settings-box-left (6 Fields)” if changing the field or fields Lexicon
  4. Extra credit: Manually edit the actual Lexicon file entry for tvs_long and add an escaped single quote in the value, again clearing cache and verifying grid operation. I add this as the custom db entries might already be encoded (I didn't look into this, but I wouldn't be surprised if they are)

Related issue(s)/PR(s)

Resolves #16948

Compatibility notes

n/a

Breaking change assessment

n/a

Test coverage

n/a for Extjs

Contributors

@opengeek

AI tool use

n/a

Remove custom groupTextTpl and make minor tweaks to grid column groupability and Lexicon
@smg6511 smg6511 requested review from Mark-H and opengeek as code owners May 7, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional translation interpolation in grouping templates

1 participant