Bump bitcoin-payment-instructions to bc7d03f (LNURL desc-hash relaxation)#21
Open
martinsaposnic wants to merge 1 commit into
Open
Bump bitcoin-payment-instructions to bc7d03f (LNURL desc-hash relaxation)#21martinsaposnic wants to merge 1 commit into
martinsaposnic wants to merge 1 commit into
Conversation
Picks up moneydevkit/bitcoin-payment-instructions#2, which accepts LNURL-pay BOLT11 invoices that ship a plain `d` description tag instead of the LUD-06-required `h = sha256(metadata)`. Required for mdkd's `pay`-style endpoints to succeed against LNURL servers like bringin.xyz. Note: mdkd's `ldk-node` pin (rev c3aba2a, branch lsp-0.7.0_socks-support) transitively still pulls bitcoin-payment-instructions at the old rev 6796e87. A follow-up PR to bump that branch of ldk-node is needed for mdkd to fully dedup the crate. Until then `cargo tree -d` will still show two copies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line
revbump inCargo.toml:bitcoin-payment-instructionsfrom6796e87tobc7d03f.bc7d03fcarries one commit on top of6796e87: moneydevkit/bitcoin-payment-instructions#2, which accepts LNURL-pay BOLT11 invoices with a plainddescription tag instead of the LUD-06-requiredh = sha256(metadata).Motivation
Required for mdkd's
/pay-style endpoints to succeed against LNURL servers likebringin.xyz. Those servers mint BOLT11 invoices withd = "Topup <N> sats"and nohtag, which upstreambitcoin-payment-instructions(correctly per LUD-06) rejects with"BOLT 11 invoice resolved via LNURL must have a matching description hash". We accept anyway to match Strike's permissive behavior.Companion PRs:
bc7d03f)lsp-0.7.0_accept-underpaying-htlcs_with_timing_logsbranch)Heads up: still duplicated after this PR
This PR only bumps mdkd's direct
bitcoin-payment-instructionsdep. mdkd'sldk-nodeis pinned at revc3aba2a4on thelsp-0.7.0_socks-supportbranch, which still transitively pullsbitcoin-payment-instructionsat the old rev6796e87.cargo tree -dwill still report two copies until a follow-up PR bumps thelsp-0.7.0_socks-supportbranch of ldk-node too.Test plan
cargo checkclean on this branch with the bump applied