Remove 'system' component from Boost package#61
Open
fmauch wants to merge 1 commit intomoveit:ros2from
Open
Conversation
With having system in the required components, this raises an error on ubuntu Resolute: ``` 00:00:54 CMake Error at /usr/lib/x86_64-linux-gnu/cmake/Boost-1.90.0/BoostConfig.cmake:141 (find_package): 00:00:54 Could not find a package configuration file provided by "boost_system" 00:00:54 (requested version 1.90.0) with any of the following names: 00:00:54 00:00:54 boost_systemConfig.cmake 00:00:54 boost_system-config.cmake ``` Ubuntu Resolute shipts boost 1.90. According to the [1.89 release notes](https://www.boost.org/releases/1.89.0/) the component has been dropped, mentioning that exact cmake issue. The solution should be to simply remove the component from the list. This should be backwards compatible down to boost 1.69, where ubuntu 22.04 (for ROS Humble) uses 1.74, so it should be fine to simply remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With having system in the required components, this raises an error on ubuntu Resolute:
Ubuntu Resolute ships boost 1.90. According to the 1.89 release notes the component has been dropped, mentioning that exact cmake issue. The solution should be to simply remove the component from the list. This should be backwards compatible down to boost 1.69, where ubuntu 22.04 (for ROS Humble) uses 1.74, so it should be fine to simply remove it.