Approve pull request with no issue

Author: vrigal

bot/code_review_bot/report/github.py

@@ -5,7 +5,7 @@
 import structlog
 
 from code_review_bot.report.base import Reporter
-from code_review_bot.sources.github import GithubClient
+from code_review_bot.sources.github import GithubClient, ReviewEvent
 
 logger = structlog.get_logger(__name__)
 
@@ -39,13 +39,20 @@ def publish(self, issues, revision, task_failures, notices, reviewers):
             if issue.is_publishable()
             and issue.analyzer.name not in self.analyzers_skipped
         ]
-        if not publishable_issues:
-            logger.info("No publishable issue, nothing to do")
-            return
 
-        message = f"{len(issues)} issues have been found in this revision"
+        if publishable_issues:
+            # Publish a review summarizing detected, unresolved and closed issues
+            message = f"{len(issues)} issues have been found in this revision"
+            event = ReviewEvent.RequestChanges
+        else:
+            # Simply approve the pull request
+            logger.info("No publishable issue, approving the pull request")
+            message = None
+            event = ReviewEvent.Approve
 
-        # Publish a review summarizing detected, unresolved and closed issues
         self.github_client.publish_review(
-            issues=issues, revision=revision, message=message
+            issues=issues,
+            revision=revision,
+            message=message,
+            event=event,
         )

bot/code_review_bot/sources/github.py

@@ -4,13 +4,27 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+import enum
+
 from github import Auth, GithubIntegration
 from github.PullRequest import ReviewComment
 
 from code_review_bot import Issue
 from code_review_bot.revisions import GithubRevision
 
 
+class ReviewEvent(enum.Enum):
+    """
+    Review action you want to perform.
+    https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#create-a-review-for-a-pull-request--parameters
+    """
+
+    Pending = "PENDING"
+    Approved = "APPROVE"
+    RequestChanges = "REQUEST_CHANGES"
+    Comment = "COMMENT"
+
+
 class GithubClient:
     def __init__(self, client_id: str, pem_key_path: str, installation_id: str):
         self.client_id = client_id
@@ -42,17 +56,27 @@ def _build_review_comment(self, issue):
         )
 
     def publish_review(
-        self, issues: list[Issue], revision: GithubRevision, message: str
+        self,
+        issues: list[Issue],
+        revision: GithubRevision,
+        event: ReviewEvent,
+        message: str | None = None,
     ):
         """
         Publish a review from a list of publishable issues, requesting changes to the author.
         """
         repo = self.api.get_repo(revision.repo_name)
         pull_request = repo.get_pull(revision.pull_number)
+
+        if message is None:
+            assert (
+                event == ReviewEvent.Approved
+            ), "Body can be left null only when approving a pull request"
+
         pull_request.create_review(
             commit=repo.get_commit(revision.pull_head_sha),
             body=message,
             comments=[self._build_review_comment(issue) for issue in issues],
             # https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#create-a-review-for-a-pull-request
-            event="REQUEST_CHANGES",
+            event=event.value,
         )