feat: Add onThumbnailReady callback for photo capture#3646
Closed
MikaelAmborn wants to merge 1 commit intomrousavy:mainfrom
Closed
feat: Add onThumbnailReady callback for photo capture#3646MikaelAmborn wants to merge 1 commit intomrousavy:mainfrom
MikaelAmborn wants to merge 1 commit intomrousavy:mainfrom
Conversation
Add support for generating thumbnails during photo capture with an asynchronous callback that fires before the full photo is saved. This enables instant preview functionality and better UX in camera applications. **Changes:** - Add `thumbnailSize` and `onThumbnailReady` options to `TakePhotoOptions` - Add `ThumbnailFile` type for thumbnail metadata - iOS: Extract embedded thumbnail from AVCapturePhoto using ImageIO for maximum performance - Android: Implement memory-efficient downsampling with hardware-accelerated decoding - Add event bridge `onThumbnailReady` for both platforms - Update documentation with usage examples and platform implementation details - Add thumbnail display in example app **Platform implementations:** - iOS: Uses embedded thumbnail from camera capture if available - Android: Uses BitmapFactory.Options.inSampleSize for efficient downsampling without loading full image into memory Both implementations are asynchronous and non-blocking. Tested on iPhone 14, iOS 18.6.2 Android implementation compiles successfully (needs device testing)
|
@MikaelAmborn is attempting to deploy a commit to the mrousavy's Team Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Hey - thanks for your PR, I really appreciate it! And sorry for not replying sooner, I was hyper-focused on VisionCamera V5. Exciting news: I believe this is now obsolete, as VisionCamera V5 now supports this! 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add support for generating thumbnails during photo capture with an asynchronous callback that fires before the full photo is saved. This enables fast preview functionality without loading the full image.
Changes
thumbnailSizeandonThumbnailReadyoptions toTakePhotoOptionsThumbnailFiletype for thumbnail metadataonThumbnailReadyfor both platformsPlatform implementations
Both implementations are asynchronous and non-blocking.
Disclaimer: I'm not an iOS or Android developer but have relied on Cursor to implement this.
Tested on
iPhone 14, iOS 18.6.2
Android implementation compiles successfully (needs device testing)