Add Uci::add_list#22
Closed
MarkusPettersson98 wants to merge 9 commits intonamib-project:mainfrom
Closed
Conversation
It was assumed that the &str argument containing the directory was indeed a valid directory, which is likely but not enforced by the API. The corresponding libuci functions are sparsely documented, but the also assume a valid directory name.
Add common helper methods for working with the unsafe uci C-ffi.
Hold onto the global mutex for the entire duration of Uci::delete to prevent a potential race between calling get_ptr and uci_delete.
Contributor
Author
|
Closing in favor of #24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds safe wrappers for
uci_add_listanduci_save, exposingUci::add_listas a public API.Uci::savecould potentially be made public, but for now it uses the privateUciPointertype so I skipped that. The PR also contains some cleanup commits unlocked by addingUci::save, along with a potential time-of-check to time-of-use bug fix inUci::delete.I would love to have
Uci::add_listin order to set DHCP options.This PR builds on top of #21. I can split it up if you desire.