Reduce security-audit warnings#664
Open
eval-exec wants to merge 3 commits intonervosnetwork:developfrom
Open
Conversation
eval-exec
changed the title
eval-exec
force-pushed
the
codex/fix-security-check-target
branch
from
a9866bd to
2d4d892
Compare
eval-exec
commented
May 6, 2026
Comment on lines
72
to
+76
| ignore = [ | ||
| "RUSTSEC-2021-0145", | ||
| "RUSTSEC-2021-0145", # atty: Windows unaligned read; migrate away from atty in follow-up | ||
| "RUSTSEC-2024-0421", # https://rustsec.org/advisories/RUSTSEC-2024-0421 | ||
| "RUSTSEC-2026-0009" # CVE: RFC2822 parser stack recursion in time 0.3.41 | ||
| "RUSTSEC-2026-0009", # CVE: RFC2822 parser stack recursion in time 0.3.41 | ||
| "RUSTSEC-2026-0097" # rand 0.7.3; transitive through older dependency stack |
Collaborator
Author
There was a problem hiding this comment.
We should create follow-up PRs to fix these CVE issues.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce cargo-deny / security-audit noise by updating dependency sources/versions (notably moving bitcoin from a pinned git rev to crates.io) and adjusting advisory ignore settings.
Changes:
- Switch
bitcoindependency from a pinnedrust-bitcoingit revision tobitcoin = 0.33.0-betain workspace crates. - Update
Cargo.lockto pick up newer, non-yankedfutures0.3.x entries and refreshed transitive dependencies. - Update
deny.tomladvisory ignore list (formatting + additional ignore entry).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
deny.toml |
Adjusts RustSec advisory ignore entries and adds a new ignore. |
ckb-signer/src/keystore/mod.rs |
Updates BIP32/secp256k1 usage to match the crates.io bitcoin API and handle key type mismatches. |
ckb-signer/Cargo.toml |
Moves bitcoin dependency to crates.io 0.33.0-beta. |
Cargo.toml |
Moves workspace bitcoin dependency to crates.io 0.33.0-beta. |
Cargo.lock |
Refreshes locked dependency graph (bitcoin-related crates, futures 0.3.32, and new transitive deps). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
72
to
+76
| ignore = [ | ||
| "RUSTSEC-2021-0145", | ||
| "RUSTSEC-2021-0145", # atty: Windows unaligned read; migrate away from atty in follow-up | ||
| "RUSTSEC-2024-0421", # https://rustsec.org/advisories/RUSTSEC-2024-0421 | ||
| "RUSTSEC-2026-0009" # CVE: RFC2822 parser stack recursion in time 0.3.41 | ||
| "RUSTSEC-2026-0009", # CVE: RFC2822 parser stack recursion in time 0.3.41 | ||
| "RUSTSEC-2026-0097" # rand 0.7.3; transitive through older dependency stack |
| "RUSTSEC-2024-0421", # https://rustsec.org/advisories/RUSTSEC-2024-0421 | ||
| "RUSTSEC-2026-0009" # CVE: RFC2822 parser stack recursion in time 0.3.41 | ||
| "RUSTSEC-2026-0009", # CVE: RFC2822 parser stack recursion in time 0.3.41 | ||
| "RUSTSEC-2026-0097" # rand 0.7.3; transitive through older dependency stack |
Comment on lines
872
to
+877
| let message = secp256k1::Message::from_digest_slice(message.as_bytes()) | ||
| .expect("Convert to message failed"); | ||
| let sub_sk = self.sub_privkey(path); | ||
| SECP256K1.sign_ecdsa(&message, &sub_sk.private_key) | ||
| let private_key = secp256k1::SecretKey::from_slice(&sub_sk.private_key.to_secret_bytes()) | ||
| .expect("valid secp256k1 secret key"); | ||
| SECP256K1.sign_ecdsa(&message, &private_key) |
Comment on lines
884
to
+889
| let message = secp256k1::Message::from_digest_slice(message.as_bytes()) | ||
| .expect("Convert to message failed"); | ||
| let sub_sk = self.sub_privkey(path); | ||
| SECP256K1.sign_ecdsa_recoverable(&message, &sub_sk.private_key) | ||
| let private_key = secp256k1::SecretKey::from_slice(&sub_sk.private_key.to_secret_bytes()) | ||
| .expect("valid secp256k1 secret key"); | ||
| SECP256K1.sign_ecdsa_recoverable(&message, &private_key) |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation