chore: upgrade rust-toolchain to 1.95.0 and fix clippy warnings#665
Open
eval-exec wants to merge 6 commits intonervosnetwork:developfrom
Open
chore: upgrade rust-toolchain to 1.95.0 and fix clippy warnings#665eval-exec wants to merge 6 commits intonervosnetwork:developfrom
eval-exec wants to merge 6 commits intonervosnetwork:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the project’s Rust toolchain to 1.95.0 (using rust-toolchain.toml) and removes a few redundant iterator conversions to satisfy newer clippy lints.
Changes:
- Replace plain-text
rust-toolchainwithrust-toolchain.tomltargeting Rust 1.95.0. - Fix clippy
useless_conversionwarnings by removing redundant.into_iter()calls in a few loops.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/subcommands/wallet.rs | Removes redundant .into_iter() when chaining derived key sets. |
| src/subcommands/util.rs | Removes redundant .into_iter() when chaining derived key sets in path search. |
| src/subcommands/tx.rs | Removes redundant .into_iter() on outputs_data() in output iteration. |
| rust-toolchain.toml | Introduces TOML toolchain pin to Rust 1.95.0. |
| rust-toolchain | Removes the old plain-text toolchain pin (1.92.0). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+2
| [toolchain] | ||
| channel = "1.95.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust-toolchainto TOML format (rust-toolchain.toml)useless_conversionwarnings (redundant.into_iter()calls)