Skip to content

chore: upgrade rust-toolchain to 1.95.0 and fix clippy warnings#665

Open
eval-exec wants to merge 6 commits intonervosnetwork:developfrom
eval-exec:exec/toolchain
Open

chore: upgrade rust-toolchain to 1.95.0 and fix clippy warnings#665
eval-exec wants to merge 6 commits intonervosnetwork:developfrom
eval-exec:exec/toolchain

Conversation

@eval-exec
Copy link
Copy Markdown
Collaborator

Summary

  • Upgrade rust-toolchain from 1.92.0 to 1.95.0
  • Switch from plain text rust-toolchain to TOML format (rust-toolchain.toml)
  • Fix 3 clippy useless_conversion warnings (redundant .into_iter() calls)

Copilot AI review requested due to automatic review settings May 6, 2026 12:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the project’s Rust toolchain to 1.95.0 (using rust-toolchain.toml) and removes a few redundant iterator conversions to satisfy newer clippy lints.

Changes:

  • Replace plain-text rust-toolchain with rust-toolchain.toml targeting Rust 1.95.0.
  • Fix clippy useless_conversion warnings by removing redundant .into_iter() calls in a few loops.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/subcommands/wallet.rs Removes redundant .into_iter() when chaining derived key sets.
src/subcommands/util.rs Removes redundant .into_iter() when chaining derived key sets in path search.
src/subcommands/tx.rs Removes redundant .into_iter() on outputs_data() in output iteration.
rust-toolchain.toml Introduces TOML toolchain pin to Rust 1.95.0.
rust-toolchain Removes the old plain-text toolchain pin (1.92.0).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rust-toolchain.toml
Comment on lines +1 to +2
[toolchain]
channel = "1.95.0"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants