ci: remove benchmark tests from CI#5144
Open
eval-exec wants to merge 1 commit intonervosnetwork:developfrom
Open
ci: remove benchmark tests from CI#5144eval-exec wants to merge 1 commit intonervosnetwork:developfrom
eval-exec wants to merge 1 commit intonervosnetwork:developfrom
Conversation
eval-exec
requested review from
Copilot and
doitian
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces CI resource usage by removing benchmark test execution from the default PR/push CI workflows while keeping benchmarking available via the dedicated manual/scheduled workflow.
Changes:
- Deleted the per-OS
ci_benchmarks_*GitHub Actions workflows. - Removed
bench-testfrom themake citarget (keepsbench-testavailable for local use). - Updated CI documentation to remove benchmark workflow references (partially).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
docs/ci-workflow.md |
Removes benchmark workflow entry from the documented CI workflow list. |
Makefile |
Drops bench-test from the ci target’s prerequisite list. |
.github/workflows/ci_benchmarks_ubuntu.yaml |
Removes Ubuntu benchmark workflow previously triggered on PR/push. |
.github/workflows/ci_benchmarks_macos.yaml |
Removes macOS benchmark workflow previously triggered on PR/push. |
.github/workflows/ci_benchmarks_windows.yaml |
Removes Windows benchmark workflow previously triggered on PR/push. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
128
to
133
| CI workflows are organized by job type and OS: | ||
|
|
||
| - `ci_quick_checks_ubuntu.yaml` / `ci_quick_checks_macos.yaml` | ||
| - `ci_unit_tests_ubuntu.yaml` / `ci_unit_tests_macos.yaml` | ||
| - `ci_integration_tests_ubuntu.yaml` / `ci_integration_tests_macos.yaml` / `ci_integration_tests_windows.yaml` | ||
| - `ci_benchmarks_ubuntu.yaml` / `ci_benchmarks_macos.yaml` | ||
| - `ci_linters_ubuntu.yaml` / `ci_linters_macos.yaml` |
eval-exec
force-pushed
the
exec/remove-bench-test
branch
from
a9d6f9c to
e2c9c04
Compare
Remove the three CI benchmark workflow files (ubuntu, macos, windows) that ran `make bench-test` on every PR/push/merge_group. Also remove bench-test from the Makefile ci target and update docs/ci-workflow.md. The `bench-test` Makefile target and `benchmark.yml` workflow (manual/scheduled) are preserved for local and on-demand use. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eval-exec
force-pushed
the
exec/remove-bench-test
branch
from
2f943b4 to
7b807a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: Benchmark tests (
make bench-test) run on every PR/push across three OS workflows, consuming CI resources unnecessarily.What is changed and how it works?
What's Changed:
ci_benchmarks_ubuntu.yaml,ci_benchmarks_macos.yaml,ci_benchmarks_windows.yamlworkflow filesbench-testfrom the Makefilecitargetdocs/ci-workflow.mdto remove benchmark workflow referencesThe
bench-testMakefile target is preserved for local use. Thebenchmark.ymlworkflow (manual/scheduled) is unaffected.Related changes
Check List
Tests
Side effects