Remove torut dependency#5202
Draft
eval-exec wants to merge 1 commit intonervosnetwork:developfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
CKB depended on
torutfor onion service key/address handling and Tor controller commands. That dependency also pulled in old transitive crates that requiredcargo-denyRustSec ignores.What is changed and how it works?
What's Changed:
torutfrom workspace dependencies andCargo.lock.PROTOCOLINFO,AUTHENTICATE, cookie/SAFECOOKIE authentication,GETINFO, andADD_ONION.torut-specific RustSec ignore entries fromdeny.toml.Related changes
owner/repo: noneCheck List
Tests
Manual test details:
Also attempted:
This failed in the local native
tikv-jemalloc-sysbuild before reaching launcher code.Side effects