Sqlite#40
Open
gpBlockchain wants to merge 12 commits intomainfrom
Open
Conversation
* Initial plan * Migrate Fiber RPC: peer_id → pubkey, node_id → pubkey - Rename get_peer_id() to get_pubkey() in FiberRPCClient and Fiber classes - Change get_pubkey() to return node_info()["pubkey"] instead of extracting PeerId from addresses - Replace "peer_id" with "pubkey" in all RPC parameters (open_channel, list_channels, disconnect_peer) - Replace "peer_id" with "pubkey" in all RPC response field accesses (list_channels, list_peers) - Replace "node_id" with "pubkey" in all RPC response field accesses (node_info, graph_nodes) - Update docstrings in fiber_rpc.py to reflect new API format - Fix hardcoded base58 PeerId to hex pubkey format in disconnect_peer test - Remove invalid assertion comparing pubkey with PeerId from address in list_peers test - Update variable names in framework helper methods for consistency Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com> * Address review feedback: fix hardcoded base58 PeerIds and simplify wasm_rpc test - test_disconnect_peer.py: Replace all-zeros key with valid well-formed hex pubkey - test_linked.py: Replace base58 PeerId with valid hex pubkey format - test_wasm_rpc.py: Remove redundant list_peers loop; use wasm_node_id directly - test_fiber2.py: Fix commented-out base58 PeerId to hex pubkey format - fiber_other_tx.py: Fix commented-out JSON with base58 PeerId values to hex pubkey format Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com> * Address second review round: rename stale peer_id variables/params to pubkey - test_wasm_watch_tower.py: rename wasm_node_id → wasm_node_pubkey - test_wasm_rpc.py: rename wasm_node_id → wasm_node_pubkey - test_list_peers.py: replace redundant is-not-None assert with len==66 format check - test_send_payment_with_router.py: fix log labels peer_id → pubkey (both occurrences) - test_build_router.py: fix log labels peer_id → pubkey - testnet/test_fiber.py: rename wait_for_channel_state param peer_id → pubkey - mainnet/test_fiber.py: rename wait_for_channel_state param peer_id → pubkey - test_mutil_sig.py: rename fiber2_peer_id → fiber2_pubkey - test_restart.py: rename fiber1_peer_id → fiber1_pubkey Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com> * Rename _get_channel_id param peer_id → pubkey in test_oneway_channel.py Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com> * Add tests for connecting to peers via pubkey in test_connect_peer.py - Implemented success case for connecting to a peer using pubkey after saving the address. - Added failure case to handle attempts to connect using an unknown pubkey, verifying appropriate error handling. These tests enhance the coverage for peer connection scenarios in the Fiber framework. * update old version fiber --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* send payment failed if oneway * del test_accept_channel.py * formate code * add p0 testcases for trampoline * update test_trampoline_invoice_success cases * wait dev fix * add p0 p1 case * add algo invoice * trampoline_hops Vec<pubkey> * add fiber test skills * add fiber skills * add fnn-cli testcases * add test_list_payments_rpc.py * adapt fnn-cli auth * format code by black * format framework/fnn_cli * Update fnn-cli and tests for peer_id → pubkey migration (#35) * Initial plan * Update fnn-cli and tests for peer_id → pubkey migration per issue #29 Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com> --------- Co-authored-by: iu小迷弟 <45781590+15168316096@users.noreply.github.com> Co-authored-by: 15168316096 <15168316096@163.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
…#37) * Initial plan * Upgrade Fiber RPC: ChannelState/state_flags to PascalCase, invoice attrs to snake_case, ckbhash to ckb_hash Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com>
…cript - Consolidated test job steps in the GitHub Actions workflow by utilizing a shared workflow file for multiple test cases. - Updated the default branch and URL in the prepare.sh script to point to the new repository. - Added SQLite feature builds for the fnn and fnn-cli binaries in the prepare script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.