hp_procurve_show_interfaces_brief: support stacked port names#2311
Open
julmanglano wants to merge 1 commit intonetworktocode:masterfrom
Open
hp_procurve_show_interfaces_brief: support stacked port names#2311julmanglano wants to merge 1 commit intonetworktocode:masterfrom
julmanglano wants to merge 1 commit intonetworktocode:masterfrom
Conversation
julmanglano
requested review from
itdependsnetworks,
jmcgill298,
jvanderaa,
matt852 and
mjbear
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
hp_procurve,
show interfaces briefSUMMARY
The
PORTcapture group was anchored to[a-zA-Z0-9\-]+, which excludesthe
/character used in stacked-switch port naming.On a stacked HP/Aruba ProCurve switch, ports are named
1/1,1/2,…,
2/1, etc. None of those names match the existing regex, so theshowintbrief2state hits its catch-all^. -> Errorrule and parsingaborts on the very first interface.
This PR broadens the regex to
[a-zA-Z0-9\-/]+, allowing the slash.No other capture groups change, no schema change, and the five existing
fixtures (standalone-switch outputs) continue to pass.
The new
show_interfaces_brief2.{raw,yml}fixture covers an 84-rowstacked output with a mix of
1/N,2/N, and trunk-named ports.