Issue #5244 Fix drag & drop to group for contacts without prior click

[kaibrockelt]

Fixes #5244

What was broken

Dragging a contact into a group only worked if the contact had been clicked before. Without a prior click, no PUT request was sent and the group assignment was silently dropped.

Root cause

Without a prior click (which triggers a full PROPFIND), the contact object is not set in a satisfactionary way — the contact is only hydrated from the initial listing. By loading the contact before adding the groups, the updateContact action now accepts the object, and no longer skipps silently.

Fix

Call fetchFullContact in the drop handler before proceeding with the group assignment.

Testing:

The onDrop handler is hard to unit test in isolation (async DAV calls, Vuex store, DOM events). I added unit tests for the Contact.groups setter which is at the core of the fix. Manual testing was done for the following scenarios — see video below:

• dragging without clicking from "All contacts" list
• dragging without clicking from "Ungrouped contacts" list
• dragging without clicking from any named list to another

https://drive.google.com/file/d/1jZ0OnXgLvYKriTLuYLomdrjkNBSkK17N/view?usp=sharing

[codecov]

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...c/components/AppNavigation/GroupNavigationItem.vue	0.00%	5 Missing ⚠️

📢 Thoughts on this report? Let us know!

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)