Skip to content

Fix: enforce minimum team name length (>=3) in UI#5292

Open
JSchut96 wants to merge 1 commit into
nextcloud:mainfrom
JSchut96:fix/team-name-min-length
Open

Fix: enforce minimum team name length (>=3) in UI#5292
JSchut96 wants to merge 1 commit into
nextcloud:mainfrom
JSchut96:fix/team-name-min-length

Conversation

@JSchut96
Copy link
Copy Markdown

Issue
Based on: #3254

The backend enforces a minimum team name length of 3 characters and returns a 400 Bad Request when this requirement is not met (e.g. "Circle name is too short").

However, the UI does not properly handle or display the error message from the server, leaving the user without a clear indication of why their submission failed.

Proposed Solution
Instead of focusing on improving error message display, this fix prevents invalid team names from being submitted altogether.

The solution:

  • Ensures the "Create team" button is only enabled when the team name meets the length requirement.
  • Prevents the form from being submitted via the Enter key if the name is invalid.
  • Communicates the length requirement within the input placeholder and shows a helpful error/hint when the name does not meet the minimum character count.

Copy link
Copy Markdown
Contributor

@DerDreschner DerDreschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you very much for your pull request! Could you please change the code so the CI runs are green?

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@JSchut96 JSchut96 force-pushed the fix/team-name-min-length branch 4 times, most recently from 2a286cc to ec5fb91 Compare May 1, 2026 12:31
Signed-off-by: JSchut96 <jeroen.schut@hotmail.com>
@JSchut96 JSchut96 force-pushed the fix/team-name-min-length branch from ec5fb91 to 3a8a0b5 Compare May 7, 2026 08:51
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews feature: teams ex circles labels May 7, 2026
@github-actions
Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: teams ex circles feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants