chore(lint): fix eslint warnings#5322
Open
hamza221 wants to merge 5 commits into
Open
Conversation
Add missing @param descriptions, fix mismatched param names, and remove disallowed `any` type tag in JSDoc for circles, validate, addressbookUtils, and matchTypes. AI-assisted: Claude Code (Claude Opus 4.7) Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Add missing @param descriptions/types, drop spurious destructuring root entries (data.addressbook.x, root0) in favor of a single destructuring parent, and escape the inline @mentions reference in CircleDetails. AI-assisted: Claude Code (Claude Opus 4.7) Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Declare emitted events on components that emit without listing them in the emits option, silencing vue/require-explicit-emits. AI-assisted: Claude Code (Claude Opus 4.7) Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Drop template refs and props that were declared but never accessed. Cascading cleanups: drop the dead onAvatarClick handler in OrgChart and its now-unused 'that' alias, drop ContactDetailsProperty's contacts and ContactDetails' contacts pass-through, and remove the never-passed desc prop on ReadOnlyContactDetails. For PropertySelect/PropertyText, the value prop is consumed via PropertyMixin so the rule is suppressed with a targeted disable comment. AI-assisted: Claude Code (Claude Opus 4.7) Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
- Register IconLoading in MemberList and NcButton in MemberListItem (vue/no-undef-components). - Drop the dead <UserGroupContent> reference in Contacts.vue; selectedUserGroup is already handled by CircleContent->UserGroupDetails. - Require explicit values for previously-true boolean defaults (CircleContent.loading, ContactsContent.loading), set ConfirmationDialog.disabled default to false, and suppress vue/no-boolean-default on EntityPicker.internalSearch where default true is the documented opt-out semantic. - Rename shadowing loop vars (emailAddress, value) in template v-for. - Give PropertyTitle.bus an explicit default. - Suppress vue/no-v-html on already-escaped formattedSubtitle spans and vue/one-component-per-file on OrgChart (ChartTemplate is mounted via createApp for d3 node rendering). AI-assisted: Claude Code (Claude Opus 4.7) Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
hamza221
changed the title
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-assisted: Claude Code (Claude Opus 4.7)