fix(csp): replace non-existent addAllowedChildSrcDomain with addAllow…#17716
Merged
nickvergessen merged 1 commit intomainfrom Apr 14, 2026
Merged
fix(csp): replace non-existent addAllowedChildSrcDomain with addAllow…#17716nickvergessen merged 1 commit intomainfrom
nickvergessen merged 1 commit intomainfrom
Conversation
Member
|
Member
|
More in apps/spreed/lib/Controller/PageController.php it seems |
…meDomain addAllowedChildSrcDomain was removed from the server in nextcloud/server#59544. Replace with addAllowedFrameDomain which, together with the existing addAllowedWorkerSrcDomain, covers the same scope as child-src. AI-Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/noid/csp-issue
branch
from
d2b0665 to
6e5be85
Compare
nickvergessen
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…edFrameDomain
addAllowedChildSrcDomain was never part of the server's public CSP API. Replace with addAllowedFrameDomain, which together with the existing addAllowedWorkerSrcDomain covers the same scope as child-src.
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required