Skip to content

fix: disable wasm highlighter for big endian platforms#769

Merged
ovflowd merged 2 commits intonodejs:mainfrom
kxxt:big-endiian
Apr 14, 2026
Merged

fix: disable wasm highlighter for big endian platforms#769
ovflowd merged 2 commits intonodejs:mainfrom
kxxt:big-endiian

Conversation

@kxxt
Copy link
Copy Markdown
Member

@kxxt kxxt commented Apr 14, 2026

Description

In PR fix: disable wasm highlighter on riscv64, as an unrelated change, the wasm highlighter is re-enabled for s390x given the corresponding bug has been fixed. It later broke node.js CI in nodejs/node#62512 because the wasm highlighter is not compatible with big endian platforms like s390x.

Thus disable the wasm highlighter for all big endian platforms until it is fixed.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

@kxxt kxxt requested a review from a team as a code owner April 14, 2026 12:36
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Apr 14, 2026 4:03pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 14, 2026

PR Summary

Low Risk
Low risk: a small runtime guard changes when the WASM highlighter is enabled, primarily affecting syntax highlighting performance/compatibility on big-endian architectures.

Overview
Disables the WASM-backed Shiki highlighter on all big-endian platforms by gating wasm behind endianness() === 'LE' (while keeping the existing riscv64 restriction).

Bumps the package version from 1.3.3 to 1.3.4 (including the lockfile) to ship the fix.

Reviewed by Cursor Bugbot for commit 9d222a1. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.44%. Comparing base (3d00fa8) to head (9d222a1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #769   +/-   ##
=======================================
  Coverage   78.43%   78.44%           
=======================================
  Files         157      157           
  Lines       13962    13967    +5     
  Branches     1152     1152           
=======================================
+ Hits        10951    10956    +5     
  Misses       3006     3006           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@araujogui araujogui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Apr 14, 2026

@nodejs/web-infra I believe this needs to be fast-tracked as hot-fix, @kxxt last favor, could you please bump the version of doc-kit on the package.json?

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Apr 14, 2026

bump @kxxt

@kxxt
Copy link
Copy Markdown
Member Author

kxxt commented Apr 14, 2026

@nodejs/web-infra I believe this needs to be fast-tracked as hot-fix, @kxxt last favor, could you please bump the version of doc-kit on the package.json?

Done. Sorry about the delay. I was away from my computer for a while.

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Apr 14, 2026

@nodejs/web-infra I believe this needs to be fast-tracked as hot-fix, @kxxt last favor, could you please bump the version of doc-kit on the package.json?

Done. Sorry about the delay. I was away from my computer for a while.

Please do not apologize! 🙇

@ovflowd ovflowd merged commit 58d8571 into nodejs:main Apr 14, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants