Skip to content

meta: broaden stale bot#62658

Open
avivkeller wants to merge 2 commits intonodejs:mainfrom
avivkeller:broaden-stale-bot
Open

meta: broaden stale bot#62658
avivkeller wants to merge 2 commits intonodejs:mainfrom
avivkeller:broaden-stale-bot

Conversation

@avivkeller
Copy link
Copy Markdown
Member

@avivkeller avivkeller commented Apr 9, 2026

As it currently stands, in order for an issue or PR to be marked as stale, the following conditions must be true:


(For issues)

  1. The issue must be labeled feature request
  2. The issue must not be labeled never-stale
  3. The issue must have had no activity for 210 days, with a warning posted at day 180.

(For PRs)

  1. The PR must not be labeled never-stale
  2. The PR must be older than 525600 minutes (1 year)
  3. The issue must have had no activity for 180 days, with a warning posted at day 150.

I propose we change this to cover more issues and pull requests, following this new configuration:

  1. The issue or PR must not be labeled never-stale. If an issue, this also includes confirmed-bug.
  2. The issue or PR must have no activity for 240 days, with a warning posted at day 210.

I understand this will likely incur a little bit of noise for the next run, but in the end, I think it'll help not just clean up the issue tracker, but draw attention to PRs that may have fallen through the cracks.

Copilot AI review requested due to automatic review settings April 9, 2026 19:18
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 9, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Broadens and unifies the repository’s stale-item automation by expanding the stale workflow beyond feature-request-only issues and folding PR staleness handling into the same workflow, while removing now-obsolete feature-request automation documentation and a dedicated PR-stale workflow.

Changes:

  • Updates .github/workflows/stale.yml to run actions/stale for both issues and pull requests (and removes the “feature request only” targeting).
  • Removes the standalone PR stale workflow (close-stale-pull-requests.yml) in favor of the unified stale workflow.
  • Simplifies feature-request-management.md by removing the automated feature request handling section.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
doc/contributing/feature-request-management.md Removes documented automated feature-request stale/close process and related never-stale guidance.
.github/workflows/stale.yml Broadens stale bot to apply to both issues and PRs, updates messages, and adds PR configuration.
.github/workflows/close-stale-pull-requests.yml Deletes the older, separate PR stale-closure workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller avivkeller requested a review from aduh95 April 10, 2026 20:30
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants