fs: validate position argument before length === 0 early return#62674
Open
geeksilva97 wants to merge 1 commit intonodejs:mainfrom
Open
fs: validate position argument before length === 0 early return#62674geeksilva97 wants to merge 1 commit intonodejs:mainfrom
geeksilva97 wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62674 +/- ##
==========================================
+ Coverage 89.77% 89.80% +0.03%
==========================================
Files 673 699 +26
Lines 203820 216235 +12415
Branches 39175 41331 +2156
==========================================
+ Hits 182987 194199 +11212
- Misses 13152 14148 +996
- Partials 7681 7888 +207
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move position validation upwards to match documented behavior.
Fixes #62638