Open
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62680 +/- ##
==========================================
- Coverage 89.81% 88.93% -0.89%
==========================================
Files 699 699
Lines 216235 216235
Branches 41336 41246 -90
==========================================
- Hits 194216 192302 -1914
- Misses 14129 15970 +1841
- Partials 7890 7963 +73 🚀 New features to boost your workflow:
|
aduh95
reviewed
Apr 10, 2026
| ### 1. Create a status file | ||
|
|
||
| For example, to add the URL tests, add a `test/wpt/status/url.json` file. | ||
| For example, to add the URL tests, add a `test/wpt/status/url.cjs` file. |
Contributor
There was a problem hiding this comment.
Do we mean to encourage use of CJS over JSON? Shouldn't we give the two examples?
Suggested change
| For example, to add the URL tests, add a `test/wpt/status/url.cjs` file. | |
| For example, to add the URL tests, add a `test/wpt/status/url.json` or `test/wpt/status/url.cjs` file. |
Member
Author
There was a problem hiding this comment.
Do we mean to encourage use of CJS over JSON?
For the features available, yes. As it is much less destructive wrt to WPT status file backports to avoid switching from json to cjs as much as possible.
aduh95
approved these changes
Apr 10, 2026
avivkeller
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-whatwg-*note and redundant "How it works" sectionWPTRunnerAPI (concurrency,setFlags,setInitScript,setScriptModifier,pretendGlobalThisAs)*patterns in status file keysinspectoras a supportedrequiresvalue