Add BLE GAP/GATT support to the dev-esp32 branch#3473
Open
pjsg wants to merge 32 commits intonodemcu:dev-esp32from
Open
Add BLE GAP/GATT support to the dev-esp32 branch#3473pjsg wants to merge 32 commits intonodemcu:dev-esp32from
pjsg wants to merge 32 commits intonodemcu:dev-esp32from
Conversation
marcelstoer
previously requested changes
Nov 6, 2021
Fix capitalization of Bluetooth Co-authored-by: Marcel Stör <marcelstoer@users.noreply.github.com>
Member
Author
|
I'd like to get this merged -- any more input? |
marcelstoer
requested review from
jmattsson
and removed request for
marcelstoer
Member
|
As I can't assess C code I added Johny as a reviewer. |
jmattsson
reviewed
Mar 5, 2022
Member
jmattsson
left a comment
jmattsson
left a comment
There was a problem hiding this comment.
I'm not a BT expert, but on the whole this looks good!
A few comments, and a couple of fixes I'd like to see before merging, but don't wait for me to merge once you've addressed that. Let's get this landed :)
(sorry about the delay, as usual...)
jmattsson
reviewed
May 18, 2023
pjsg
changed the title
pjsg
changed the title
Member
|
Nice, is there anything else outstanding other than sorting out the merge issues? |
HHHartmann
reviewed
Feb 10, 2024
|
|
||
| ### Type conversions | ||
|
|
||
| If the `type` value converts a single item, then that will be the value that is placed into the `value` element. If it converts multiple elements, then the elements will be placed into an array that that will be placed into the `value` element. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3469
devbranch rather than for thereleasebranch.docs/*.This is the first pass at BLE support. There is some more tidyup to do, and also enabling it is slightly tricky as it is built on top
of the NimBLE stack -- and I can't find a way to force enable that stack from the Kconfig.
You can startup and shutdown the BLE stack multiple times and it doesn't obviously leak memory.
It seems to work in my test environment.
Interested in comments.