Skip to content

fix: keep versions modal options in query params #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 2 commits into from
Feb 28, 2026
Merged

fix: keep versions modal options in query params #1725

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d764cd9
feat: keep versions modal options in query params
sybers Feb 27, 2026
1beff9b
fix: validate grouping query param
sybers Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/components/Package/Versions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ function closeDistributionModal() {
query: {
...route.query,
modal: undefined,
grouping: undefined,
recent: undefined,
lowUsage: undefined,
},
})

Expand Down
16 changes: 13 additions & 3 deletions app/composables/useVersionDistribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ interface ChartDataItem {
* @returns Reactive state and computed chart data
*/
export function useVersionDistribution(packageName: MaybeRefOrGetter<string>) {
const groupingMode = ref<VersionGroupingMode>('major')
const showRecentOnly = ref(false)
const showLowUsageVersions = ref(false)
const groupingMode = useRouteQuery<VersionGroupingMode>('grouping', 'major', { mode: 'replace' })
const showRecentOnly = useBooleanRouteQuery('recent', false)
const showLowUsageVersions = useBooleanRouteQuery('lowUsage', false)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
const pending = ref(false)
const error = ref<Error | null>(null)
const data = ref<VersionDistributionResponse | null>(null)
Expand Down Expand Up @@ -173,3 +173,13 @@ export function useVersionDistribution(packageName: MaybeRefOrGetter<string>) {
fetchDistribution,
}
}

function useBooleanRouteQuery(key: string, defaultValue = false) {
return useRouteQuery(key, defaultValue ? 'true' : 'false', {
transform: {
get: (v: string) => v === 'true',
set: (v: boolean) => (v ? 'true' : 'false'),
},
mode: 'replace',
})
}
Loading