Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions app/pages/blog/index.stories.ts
Copy link
Copy Markdown
Contributor

@cylewaitforit cylewaitforit May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new story renders fine in the PR's deployed storybook .

@ghostdevv I don't have access to check the Chromatic tests anymore so you may want to check what the visual regression tests capture.

It looks like the blogs that are being displayed are live data. So my assumption is that would probably mean the chromatic tests would suddenly be out of date when a new blog post is added.

So while I know both are ultimately wanted, we would need to decide if disabling visual regression tests on this page to start would be a blocker to merging or if increasing the coverage of our documented pages is a fine enough short term goal.

If documenting to start is the more important goal then we could add the chromatic parameter to disable.

const meta = {
  component: Blog,
  parameters: {
    layout: 'fullscreen",
    // Disables Chromatic's snapshotting on a component level
    chromatic: { disableSnapshot: true },
  },
  decorators: [pageDecorator],
} satisfies Meta<typeof Blog>;

https://www.chromatic.com/docs/disable-snapshots/#with-storybook

We would probably want to then add a follow up issue to mock out the blog posts in order to re-enable snapshots.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update:

I have access to the chromatic tests again and understandably the snapshot has the same live data. So I think my assumption that new blog data would cause the snapshot to become outdated seems correct.

Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import Blog from './index.vue'
import type { Meta, StoryObj } from '@storybook-vue/nuxt'
import { pageDecorator } from '../../../.storybook/decorators'

const meta = {
component: Blog,
parameters: {
layout: 'fullscreen',
},
decorators: [pageDecorator],
} satisfies Meta<typeof Blog>

export default meta
type Story = StoryObj<typeof meta>

export const Default: Story = {}
Loading