Skip to content

ir: support new metadata chain flow#3984

Open
carpawell wants to merge 1 commit into
masterfrom
feat/meta/ir
Open

ir: support new metadata chain flow#3984
carpawell wants to merge 1 commit into
masterfrom
feat/meta/ir

Conversation

@carpawell
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 0% with 213 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.84%. Comparing base (103d05c) to head (58ae7e5).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
pkg/innerring/innerring.go 0.00% 119 Missing ⚠️
pkg/innerring/processors/meta_placement.go 0.00% 45 Missing ⚠️
...nnerring/processors/container/process_container.go 0.00% 28 Missing ⚠️
pkg/innerring/processors/netmap/process_epoch.go 0.00% 15 Missing ⚠️
pkg/innerring/processors/container/processor.go 0.00% 3 Missing ⚠️
pkg/innerring/internal/metachain/chain.go 0.00% 2 Missing ⚠️
pkg/innerring/processors/netmap/processor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3984      +/-   ##
==========================================
- Coverage   27.95%   27.84%   -0.11%     
==========================================
  Files         684      683       -1     
  Lines       45755    45833      +78     
==========================================
- Hits        12792    12764      -28     
- Misses      31771    31876     +105     
- Partials     1192     1193       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carpawell carpawell marked this pull request as ready for review May 12, 2026 15:35
Comment thread pkg/innerring/processors/meta_placement.go Outdated
@roman-khimov
Copy link
Copy Markdown
Member

Requires test adjustments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces support for an experimental “metadata sidechain” flow in Inner Ring, wiring a meta-chain notary actor into IR processors so that metadata containers can be registered and their placements updated alongside the main FS-chain placement updates.

Changes:

  • Add meta-chain bootstrap in IR (custom natives, ports remapping, notary deposit, notary actor creation) and pass the meta actor into processors.
  • Update container processor to register a metadata container and push its initial placement to the meta sidechain.
  • Update netmap epoch processing to also update meta-container placements when the container has the metadata-consistency attribute.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
pkg/innerring/processors/netmap/processor.go Adds optional meta notary actor to netmap processor params/state.
pkg/innerring/processors/netmap/process_epoch.go Triggers meta-chain placement updates during epoch placement refresh.
pkg/innerring/processors/meta_placement.go New helper for building/sending meta-chain placement update notary calls + VUB calculation.
pkg/innerring/processors/container/processor.go Adds meta actor dependency validation when meta feature is enabled.
pkg/innerring/processors/container/process_container.go Registers meta container and updates its placement on meta sidechain during container approval.
pkg/innerring/internal/metachain/chain.go Adds helper to build a meta sidechain blockchain with custom natives.
pkg/innerring/innerring.go Boots meta sidechain, builds meta notary actor, introduces worker error propagation, adds port remapping helper.
pkg/innerring/config/config.go Changes experimental.chain_meta_data from bool to structured metadata-chain config.
config/example/ir.yaml Updates example config for new experimental.chain_meta_data structure.
cmd/neofs-ir/validate_test.go Updates config validation test for new metadata config structure.
cmd/neofs-ir/defaults_test.go Updates defaults validation test for new metadata config structure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/innerring/innerring.go
Comment thread pkg/innerring/innerring.go Outdated
Comment thread pkg/innerring/innerring.go
Comment thread pkg/innerring/innerring.go Outdated
Comment thread pkg/innerring/config/config.go Outdated
Comment thread pkg/innerring/processors/meta_placement.go Outdated
Comment thread pkg/innerring/processors/container/process_container.go Outdated
Comment thread pkg/innerring/processors/container/processor.go Outdated
Comment thread pkg/innerring/processors/netmap/process_epoch.go
Comment thread pkg/innerring/innerring.go Outdated
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to nspcc-dev/neofs-testcases that referenced this pull request May 15, 2026
Refs nspcc-dev/neofs-node#3984.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants