Skip to content

Replace parallel EC GET with paired stream#3998

Draft
cthulhu-rider wants to merge 2 commits into
masterfrom
ec-get-2-routines
Draft

Replace parallel EC GET with paired stream#3998
cthulhu-rider wants to merge 2 commits into
masterfrom
ec-get-2-routines

Conversation

@cthulhu-rider
Copy link
Copy Markdown
Contributor

this approach seems more cost-effective overall. However, basic load tests did not show any increase in throughput. Therefore lets resolve this issue separately

Closes #3952. Refs #3098,

Signed-off-by: cthulhurider <ctulhurider@gmail.com>
Refs #3952.

Signed-off-by: cthulhurider <ctulhurider@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 5.43580% with 1009 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.80%. Comparing base (84ededb) to head (087994b).

Files with missing lines Patch % Lines
pkg/services/object/get.go 2.55% 720 Missing and 5 partials ⚠️
pkg/services/object/get/ec.go 2.31% 167 Missing and 2 partials ⚠️
pkg/services/object/proto.go 0.00% 46 Missing ⚠️
pkg/services/object/server.go 41.17% 19 Missing and 1 partial ⚠️
pkg/network/cache/clients.go 40.90% 13 Missing ⚠️
internal/object/wire.go 40.00% 9 Missing ⚠️
internal/protobuf/seekers.go 0.00% 8 Missing ⚠️
pkg/services/object/util.go 33.33% 5 Missing and 3 partials ⚠️
pkg/services/object/get/service.go 0.00% 5 Missing ⚠️
pkg/services/object/get/util.go 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3998      +/-   ##
==========================================
- Coverage   28.33%   27.80%   -0.54%     
==========================================
  Files         681      681              
  Lines       45753    46763    +1010     
==========================================
+ Hits        12964    13002      +38     
- Misses      31556    32524     +968     
- Partials     1233     1237       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov
Copy link
Copy Markdown
Member

OK, let's postpone this to 0.54.0 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants