fix: deprecated diagnostic jumping config#1982
fix: deprecated diagnostic jumping config#1982nathanzeng wants to merge 1 commit intonvim-lua:masterfrom
Conversation
|
Because this uses a feature ( On a related note, should we wait a bit before dropping support for 0.11? Both Ubuntu and Fedora are releasing new versions this month, and I assume they’ll include 0.12. Should we wait until those releases? (Mostly thinking out loud - though I would love to hear others' opinion) |
2ba0738 to
2194d49
Compare
|
Thanks for the review, and good catch on bumping the health check. Waiting for Ubuntu and Fedora seems like a good idea to me. |
2194d49 to
ee5cab1
Compare
- bump checkhealth minimum version to 0.12
ee5cab1 to
0983776
Compare
|
LGTM :) |
|
After checking fedora and ubuntu it seems both of them won't include 0.12 in their upcoming versions (at least at release). https://packages.fedoraproject.org/pkgs/neovim/neovim/ (reason seems to be this) https://packages.ubuntu.com/resolute/neovim (my guess is because debian-testing didn't update either). Maybe we should reconsider the timeline of dropping support. |
|
I'm not sure if you mean dropping support earlier or later, but I think either is fine. For what it's worth I think the readme for kickstart does a great job of explaining that only the latest version of neovim is supported, and pointing you to how to install it. |
|
Considering it seems like the big distros won't update to 0.12 anytime soon, I think it fine to drop support earlier. Though I think fixing a deprecation warning is not a big enough reason to do that. |
opts.jump.floatis deprecated as of the 0.12 release. To confirm, use the kickstart config and run::checkhealth vim.deprecatedThis also bumps the minimum version to 0.12