[codex] Revisit shared approval prompting#18040
Closed
abhinav-oai wants to merge 2 commits intomainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This revisits the old #17594 branch, which had the right cleanup goal but drew fair feedback that the refactor introduced too many overlapping approval concepts.
The upcoming PermissionRequest hook still wants approval prompting to be more centralized, but the shape here stays narrower: share the routing and caching helpers, and keep the concrete prompt construction local to each caller.
What
tools::approvalhelper module for guardian routing and session approval cachingApprovalStoreout oftools::sandboxinginto that helper moduleValidation
cargo test -p codex-core(currently has 2 unrelated pre-existing failures inagent::controlandplugins::manager)cargo test -p codex-core tools::network_approval::tests::cargo test -p codex-core tools::runtimes::just fix -p codex-corejust fmt