fix(tui): remove duplicate context statusline item#18054
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2cedba4de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// Percentage of context window remaining. | ||
| ContextRemaining, |
There was a problem hiding this comment.
Preserve legacy context-remaining-percent config ID
Keep backward compatibility for existing user configs. After this change, "context-remaining-percent" no longer parses as a StatusLineItem, so parse_items_with_invalids drops it. Users upgrading with tui_status_line = ["context-remaining-percent"] lose that segment (and can lose the whole status line if it was their only item). Add it as a serialize alias on ContextRemaining.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This option shipped with only one version, so I'm OK not providing backward compatibility. Users who happened to pick this option in version 0.120.0 can just run /statusline again to reconfigure.
Addresses #18045
Problem:
/statuslineexposed bothcontext-remainingandcontext-remaining-percentafter conflicting PRs attempted to address the same context-status issue, including #17637, allowing duplicate footer segments.Solution: Remove the duplicate
context-remaining-percentstatus-line item and update status-line tests and snapshots to use only canonicalcontext-remaining.