Skip to content

Fix invalid TUI resume hints#18059

Merged
etraut-openai merged 3 commits intomainfrom
etraut/resume-regression
Apr 16, 2026
Merged

Fix invalid TUI resume hints#18059
etraut-openai merged 3 commits intomainfrom
etraut/resume-regression

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented Apr 16, 2026

Addresses #18011

Problem: #16987 allowed zero-token TUI exits to print resume hints, which exposed precomputed thread ids before their rollout files were persisted; #17222 made the same invalid hint visible when switching sessions via /resume.

Solution: Only include resume commands for TUI sessions backed by a materialized non-empty rollout, and cover both missing-rollout and persisted-rollout summary behavior.

Testing: Manually verified by pressing Ctrl+D before the first prompt and confirming that no "to continue this session" message was generated.

Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replicated the issue and the fix. Approved.

@etraut-openai etraut-openai merged commit ab82568 into main Apr 16, 2026
25 checks passed
@etraut-openai etraut-openai deleted the etraut/resume-regression branch April 16, 2026 16:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants