No registry lookup in cli#2755
Open
butonic wants to merge 4 commits into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 264 |
| Duplication | 3 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
aduffeck
reviewed
May 13, 2026
Member
aduffeck
left a comment
There was a problem hiding this comment.
+1 for "endpoint".
Tests are still failing, but the change itself looks good to me.
003db32 to
d20685e
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
d20685e to
38fa1d5
Compare
Member
Author
|
meh, the tests actually execute the command ... |
315eb4e to
15ed9a0
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
15ed9a0 to
2b1c4fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the index command to use a go grpc client instead of a go micro client. It now has a
grpc-addrthat defaults to127.0.0.1:9220, the search service grpc port.It also allows using the index command when the micro service registry is set to
memory.I added the grpc client stubs to the protobuf generation in a separate commit. The change itself is small.
The only question I have is: what is a better name for the cli
grpc-addrflag. maybeendpoint? we might be usingunix:/path/to/socketat some point.Related: #2715.