Skip to content

600 feature improve GitHub testing - Add fast test workflow for GitHub Actions#625

Open
VeronicaHG wants to merge 3 commits into
devfrom
600-feature-improve-github-testing
Open

600 feature improve GitHub testing - Add fast test workflow for GitHub Actions#625
VeronicaHG wants to merge 3 commits into
devfrom
600-feature-improve-github-testing

Conversation

@VeronicaHG
Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • New and adjusted code is formatted using the pre-commit hooks
  • New and adjusted code includes type hinting now
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The Read the Docs documentation is compiling correctly
  • If new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.
  • I have added new features to the corresponding whatsnew file

@VeronicaHG VeronicaHG linked an issue May 6, 2026 that may be closed by this pull request
Comment thread tests/conftest.py Outdated
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

on: [push]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on:
push:
branches:
- dev
pull_request:

Comment thread .github/workflows/tests.yml Outdated

jobs:
fast-tests:
runs-on: ubuntu-latest
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: ubuntu-latest
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
runs-on: ubuntu-latest

Avoid duplicate runs: on internal branches, the push event already triggers this job, so skip the pull_request event for same-repo PRs. Fork PRs still run because forks don't trigger push events in the base repo.

Comment thread .github/workflows/tests.yml Outdated
python tests/run_tests_from_file.py ci/non_fast_tests.txt

full-tests:
if: github.event_name == 'pull_request'
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: github.event_name == 'pull_request'
if: github.event_name == 'pull_request' || (github.event_name == 'push' && github.ref == 'refs/heads/dev')

Run the full test suite on pull requests (any branch) and on pushes to dev. Skipped on pushes to feature branches to save CI minutes; fast-tests covers those.

@joda9 joda9 force-pushed the 600-feature-improve-github-testing branch from a6892f8 to afeb4df Compare May 20, 2026 07:34
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was macht diese Datei?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remov the fast tests from the total test datei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]Improve Github Testing

2 participants